-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Renovate configuration #72
Conversation
maybe, if we would like to be up to date to the base image, we should pin the digest? that would be something we could automerge |
@wuast94 do you have an idea on how we would pin the digest with our current |
Here we could enable pinning without a problem.
never worked with repology and i dont know if the datasource and/or renovate can pin digests there but it only makes sense if an image or package changes without changing the tag or version. for example in docker if a container only have a latest tag that will be updated then pinning makes sense to make sure to grab that specific release. otherwise some caching etc could use an older image than available. also i use it in my swarm cluster to keep non versioned containers up to date, but thats another use of pinning digests there. i looked a bit at the sources and i dont think that we really need pinning at all here? |
485dae1
to
09535f3
Compare
I imagine that |
Yeah, that sounds like the right prioritisation to me too. At least, it sounds like the right thing to start with. 😄 We can adjust that in future if it turns out to be needed, etc. |
This PR should solve a couple of issues with our Renovate configuration.
alpine
version in the Dockerfile to ensure that we also use the Alpine version for the final Docker images.alpine
version in the GitHub Actions file to ensure the tag will be correct.I tested the changes on my personal fork of the repository, looks like it does what it should: