Add support for react@17 #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wrakky can you please review |
|
@wrakky bump, it would be great if we could get this reviewed/merged |
|
@danscan please update version number |
ChristianMurphy
added a commit
to ChristianMurphy/openEquella
that referenced
this pull request
Aug 5, 2021
suggested in renovatebot/renovate#9204 this allows working around peternewnham/react-html-parser#80 and gvaldambrini/storybook-router#66 this can be removed when upstream peer conflicts have been resolved
5 tasks
|
Could we please get this merged? |
|
@durgeshrkumari maybe you want to take a look at our hard fork? |
|
Based on the time that you have been waiting, i think maybe someone could assume the development of this module as the Contributors does not seem to be interested even on merging pull requests like this. So i was going to use this module right now, but based on the situation, https://www.npmjs.com/package/html-react-parser seems to be a good fit. |
1 task
quietly-turning
added a commit
to quietly-turning/Lua-For-SM5
that referenced
this pull request
Sep 22, 2021
I performed major-version updates to most node packages. react-html-parser wasn't compatible with react 7, so I moved to a similar project, html-react-parser. See: peternewnham/react-html-parser#80 (comment) Updating @primer/octicons-react threw some errors I didn't have time to investigate, so that remains un-updated for now.
enigma1
reviewed
Oct 9, 2021
| "react": "^16.0.0", | ||
| "react-dom": "^16.0.0", | ||
| "react": "^17.0.1", | ||
| "react-dom": "^17.0.1", | ||
| "rimraf": "^2.5.2", | ||
| "webpack": "^1.13.0" | ||
| }, | ||
| "dependencies": { | ||
| "htmlparser2": "^3.9.0" |
There was a problem hiding this comment.
Without updating the htmlparser2 I am getting errors with react 17. In my tests it worked with
"dependencies": {
"htmlparser2": "^7.1.2"
},
w3bdesign
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Futurism, we are using react-html-parser with next@10 and react@17. This PR adds support for react@17.
All tests pass :)