Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry in withPage function #993

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Add retry in withPage function #993

merged 7 commits into from
Jul 18, 2024

Conversation

pankaj443
Copy link
Contributor

@pankaj443 pankaj443 commented Jul 17, 2024 •
edited
Loading

  • Adding retry in withPage function.
  • Update evalSetCurrentStory swap: setCurrentStory & updateGlobals.

Above changes are with respect to storybook v8 fixes, we were getting execution context destroyed on several stories. swapping above calls fixes this.

@pankaj443 pankaj443 requested a review from a team as a code owner July 17, 2024 09:34
@pankaj443 pankaj443 requested review from prklm10 and ninadbstack July 17, 2024 09:34
rishigupta1599
rishigupta1599 reviewed Jul 17, 2024
View reviewed changes
src/utils.js Outdated Show resolved Hide resolved
rishigupta1599
rishigupta1599 reviewed Jul 17, 2024
View reviewed changes
src/utils.js Outdated Show resolved Hide resolved
rishigupta1599
rishigupta1599 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@rishigupta1599 rishigupta1599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pankaj443 pankaj443 merged commit 57c7d75 into master Jul 18, 2024
6 checks passed
@pankaj443 pankaj443 deleted the PER_3583 branch July 18, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishigupta1599 rishigupta1599 rishigupta1599 approved these changes

@prklm10 prklm10 prklm10 approved these changes

@ninadbstack ninadbstack Awaiting requested review from ninadbstack ninadbstack is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pankaj443 @prklm10 @rishigupta1599