Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13608: honor updates settings at API level #3442

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

idoqo
Copy link
Contributor

@idoqo idoqo commented Jan 9, 2025

PMM-13608

Link to the Feature Build: SUBMODULES-3803

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@idoqo idoqo requested a review from a team as a code owner January 9, 2025 07:42
@idoqo idoqo requested review from BupycHuk and JiriCtvrtka and removed request for a team January 9, 2025 07:42
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (v3@50a8348). Learn more about missing BASE report.

Files with missing lines Patch % Lines
managed/services/server/updater.go 45.45% 11 Missing and 1 partial ⚠️
managed/services/server/server.go 0.00% 7 Missing ⚠️
managed/cmd/pmm-managed/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             v3    #3442   +/-   ##
=====================================
  Coverage      ?   43.54%           
=====================================
  Files         ?      366           
  Lines         ?    44262           
  Branches      ?        0           
=====================================
  Hits          ?    19276           
  Misses        ?    23297           
  Partials      ?     1689           
Flag Coverage Δ
managed 45.30% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff merged commit 165ad35 into v3 Jan 17, 2025
6 of 8 checks passed
@ademidoff ademidoff deleted the PMM-13608-disable-updates branch January 17, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants