-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indentation issues and modeline issue. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocket
changed the title
Indent try block
Indent try block. Properly indent a function call with arguments on the next lines.
Jun 11, 2021
It fixes #6 |
If a function call appears and its arguments appear on the next lines, the function call is indented as if it were a special form like try block.
crocket
changed the title
Indent try block. Properly indent a function call with arguments on the next lines.
Fix indentation issues.
Jun 11, 2021
It fixes #4 |
When pressing enter, remove leading spaces in the current line, and remove trailing spaces in the previous line.
* '(+)' can now be indented properly. * Indenting past the last letter of the line that has the opening parenthesis is now possible.
* non-special forms are now not recognized as special forms. * indentation code is made more efficient.
crocket
changed the title
Fix indentation issues.
Fix indentation issues and modeline issue.
Jun 12, 2021
Upper-case options are empty after `modeline-parse` is executed. Thus, janet_autolint and janet_autoformat were empty after `modeline-parse` was manually executed. Executing `:w` after executing `modeline-parse` caused janet.kak to execute jfmt and jlnt even though janet_autolint and janet_autoformat were false. By turning upper-case options to lower-case options, janet_autolint and janet_autoformat are not empty after executing `modeline-parse` automatically.
This pull request is ready. |
Sorry for the wait. I spent last week caring for all three kids, as they were sick. Yesterday CET I will merge it. |
pepe
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very nice. After I finish the job work, I will check it and merge it. Thank you very much!
I also simplified indentation code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.