Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist lints from individual packages to workspace #336

Open
wants to merge 21 commits into
base: dev-0.6
Choose a base branch
from

Conversation

caass
Copy link

@caass caass commented Jan 3, 2025

By hoisting the lint settings out from individual packages to the root Cargo.toml (and using lints.workspace = true in the individual crates), lints can be applied uniformly across all crates.

@pdeljanov
Copy link
Owner

Thanks, for this!

I'm glad this option exists to make things more consistent across all of our crates. It looks like symphonia-core wasn't using #![warn(rust_2018_idioms)] like all the other crates and it's causing the CI errors. Do you want to fix those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants