TST/REF: unify and parametrize data, backend, and client fixtures #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…along with setup_test_stack decorator for configuring all at once
|
This diff count looks crazy but it's mostly that I moved a huge function to another file 😅 |
…x of tests, given lists of test parameters
…ect children of the Root
ZLLentz
reviewed
Dec 20, 2024
| @@ -139,8 +141,8 @@ def test_page_smoke(page: str, request: pytest.FixtureRequest): | |||
| print(type(request.getfixturevalue(page))) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("filestore_backend", ["db/filestore.json"], indirect=True) | |||
| def test_apply_filter(search_page: SearchPage): | |||
| @setup_test_stack(sources=["db/filestore.json"], backend_type=FilestoreBackend) | |||
There was a problem hiding this comment.
I appreciate how readable these ended up being
ZLLentz
reviewed
Dec 20, 2024
|
No rush, I want Devan's input too, and we may have another lively discussion or two about it |
|
In that case, I'll coast through to eoy and look in the next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
test_data,test_backend, andtest_clientfixtures that can be parametrized, replacing other specialized fixtures that setup specific combinations of daa / backend / clientAdds
setup_test_stackto concisely parametrize and request the aforementionedtest_*fixturesOrganizes data-helper functions into a separate file (for my poor scrolling finger)
Adjusts existing tests to use
setup_test_stackandtest_*fixtures instead of other specialized fixturesFixes bug where TestBackend could not delete an entry that was a direct child of the
RootFixes behavior of FilestoreBackend to throw
Entry*Errorexceptions rather than just returning NoneMotivation and Context
This is the natural evolution of Devan's
filestore_backendparametrization efforts (#104) . I know I deleted it but its spirit lives on.This helps us avoid lots of fixtures that hold a very specific combination of test data, backend type, and client features.
How Has This Been Tested?
By seeing that the test suite still passes
Where Has This Been Documented?
This PR, and overly verbose docstrings
Pre-merge checklist
docs/pre-release-notes.shand created a pre-release documentation page