Add a local PMPS look up flag. #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLLentz
reviewed
Jan 26, 2024
| <?xml version="1.0" encoding="utf-8"?> | ||
| <TcPlcObject Version="1.1.0.1" ProductVersion="3.1.4022.18"> | ||
| <POU Name="FB_Read70x1CoeData" Id="{3d4514dc-8223-47db-9879-899720aca4f2}" SpecialFunc="None"> | ||
| <Declaration><
There was a problem hiding this comment.
Did a different wip branch get included in this commit accidentally? There are 2 files added that include CoE utilities.
There was a problem hiding this comment.
interesting, let me check.
There was a problem hiding this comment.
I must have branched off some dev work 😲. I fixed this.
ZLLentz
reviewed
Jan 26, 2024
| astDbStateParams=>, | ||
| bError=>, | ||
| ); | ||
| IF NOT bLocalPMPS THEN |
There was a problem hiding this comment.
I expect this to work
I wonder if this should have a more straightforward name, e.g. bUsePmpsDB
Opinions welcome
There was a problem hiding this comment.
Your suggestions looks more consistent with the code base; updated.
|
This attempt seems to have been upgraded from a quick attempt to a possible future feature request; TBD if that's really needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can delete this later and enforce DB use once LFE DB is online.
Motivation and Context
How Has This Been Tested?
Where Has This Been Documented?
Pre-merge checklist
Always Newestversion (Library, *)pre-commitor ranpre-commit run --all-files