gas needle with different motors and encoders installed #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, forgot the pre-commit run. should do that. |
|
Tong, were you going to run pre-commit and push back here? I was going to review but was going to wait if you had more commits to push. |
|
Yes, Zach. Sorry. I am busy with Sample paddle X, Y, Z test today and it is almost done except Y motor has strange noise. I will push again with pre-commit run next week. Thanks! |
|
Zach, I ran pre-commit before second PR and hope it is ok for you? |
ZLLentz
approved these changes
Jun 7, 2024
Comment on lines
-1331
to
+1335
| <Encoder Name="Enc" EncType="4"> | ||
| <EncPara ScaleFactorNumerator="9.921875e-05" MaxCount="#x0000ffff"> | ||
| <SoftEndMinControl Enable="true" Range="-100"/> | ||
| <SoftEndMaxControl Enable="true" Range="100"/> | ||
| <Inc RefMode="2" RefSoftSyncMask="#x0000ffff"/> | ||
| <ParameterChanged>8</ParameterChanged> | ||
| <Encoder Name="Enc" EncType="19"> | ||
| <EncPara ScaleFactorNumerator="5e-05" MaxCount="#xffffffff"> | ||
| <SoftEndMinControl Enable="true" Range="31"/> | ||
| <SoftEndMaxControl Enable="true" Range="52"/> | ||
| <Inc RefSoftSyncMask="#x0000ffff"/> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TMO swap the motors for gas needle by smaller size and less current.
Meanwhile, adding encoder into every axe.
Tune the parameter, link to encoder, rewrite code in main.
Motivation and Context
Request from scientists in new MRCO chamber
How Has This Been Tested?
Yes, I tested with scientists to setup soft limits and move to the whole range for every axe.
Where Has This Been Documented?
https://jira.slac.stanford.edu/browse/ECS-5513
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)