feat(storage-s3): add cacheControlMaxAge option #10438
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new configuration option for the S3 storage plugin, allowing users to specify a
cacheControlMaxAge
value in seconds.The default value is
undefined
which omits the Cache-Header keeping this change non-breaking.Before changes
No
Cache-Control
header present on uploads beging returned.After changes
If
cacheControlMaxAge
is set,Cache-Control: public, max-age={cacheControlMaxAge}
is added to uploads returned.Using plugin
CONTRIBUTING.md
document in this repository.
Type of change
Checklist: