fix: allow public errors to thread through on response #10419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When using
throw new APIResponse("Custom error message", 500, null, true)
the error message is being replaced with the standard "Something went wrong" message.Why?
We are not checking if the 4th argument (
isPublic
) is false before masquerading the error message.How?
Adds a check for
!err.isPublic
before adjusting the outgoing message.