Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow public errors to thread through on response #10419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JarrodMFlesch
Copy link
Contributor

What?

When using throw new APIResponse("Custom error message", 500, null, true) the error message is being replaced with the standard "Something went wrong" message.

Why?

We are not checking if the 4th argument (isPublic) is false before masquerading the error message.

How?

Adds a check for !err.isPublic before adjusting the outgoing message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants