Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasks component and call from todo with checks #322

Merged
merged 1 commit into from
Feb 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 41 additions & 39 deletions scilog/src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,32 +4,32 @@ import { APP_INITIALIZER, NgModule } from "@angular/core";
import { AppRoutingModule } from './app-routing.module';
import { AppComponent } from './app.component';
import { SnippetComponent } from '@shared/snippet/snippet.component';
import {MatButtonModule} from '@angular/material/button';
import {MatCardModule} from '@angular/material/card';
import {MatDialogModule} from '@angular/material/dialog';
import {MatExpansionModule} from '@angular/material/expansion';
import {MatIconModule} from '@angular/material/icon';
import {MatProgressSpinnerModule} from '@angular/material/progress-spinner';
import {MatSidenavModule} from '@angular/material/sidenav';
import {BrowserAnimationsModule } from '@angular/platform-browser/animations';
import {ScrollingModule as ExperimentalScrollingModule} from '@angular/cdk-experimental/scrolling';
import {DragDropModule} from '@angular/cdk/drag-drop';
import {ScrollingModule} from '@angular/cdk/scrolling';
import {HttpClientModule} from '@angular/common/http';
import {CKEditorModule} from '@ckeditor/ckeditor5-angular';
import { MatButtonModule } from '@angular/material/button';
import { MatCardModule } from '@angular/material/card';
import { MatDialogModule } from '@angular/material/dialog';
import { MatExpansionModule } from '@angular/material/expansion';
import { MatIconModule } from '@angular/material/icon';
import { MatProgressSpinnerModule } from '@angular/material/progress-spinner';
import { MatSidenavModule } from '@angular/material/sidenav';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { ScrollingModule as ExperimentalScrollingModule } from '@angular/cdk-experimental/scrolling';
import { DragDropModule } from '@angular/cdk/drag-drop';
import { ScrollingModule } from '@angular/cdk/scrolling';
import { HttpClientModule } from '@angular/common/http';
import { CKEditorModule } from '@ckeditor/ckeditor5-angular';
import { AddContentComponent } from '@shared/add-content/add-content.component';
import {MatMenuModule} from '@angular/material/menu';
import {MatChipsModule} from '@angular/material/chips';
import {MatFormFieldModule} from '@angular/material/form-field';
import {MatToolbarModule} from '@angular/material/toolbar';
import { MatMenuModule } from '@angular/material/menu';
import { MatChipsModule } from '@angular/material/chips';
import { MatFormFieldModule } from '@angular/material/form-field';
import { MatToolbarModule } from '@angular/material/toolbar';
import { SnippetTableComponent } from '@shared/snippet/snippet-table/snippet-table.component'
import {MatTableModule} from '@angular/material/table';
import {MatButtonToggleModule} from '@angular/material/button-toggle';
import {GridsterModule} from 'angular-gridster2';
import { MatTableModule } from '@angular/material/table';
import { MatButtonToggleModule } from '@angular/material/button-toggle';
import { GridsterModule } from 'angular-gridster2';
import { DashboardItemComponent } from './logbook/dashboard/dashboard-item/dashboard-item.component';
import { LogbookItemComponent } from './logbook/widgets/logbook-item/logbook-item.component';
import {MatDividerModule} from '@angular/material/divider';
import {MatBadgeModule} from '@angular/material/badge';
import { MatDividerModule } from '@angular/material/divider';
import { MatBadgeModule } from '@angular/material/badge';
import { DashboardComponent } from './logbook/dashboard/dashboard.component';
import { ChatComponent } from './logbook/widgets/chat/chat.component';
import { TodosComponent } from './logbook/widgets/todos/todos.component';
Expand All @@ -39,53 +39,54 @@ import { OverviewComponent } from './overview/overview.component';
import { LogbookComponent } from './logbook/logbook.component';
import { LogbookWidgetComponent } from './overview/logbook-cover/logbook-cover.component';
import { ViewWidgetComponent } from './overview/view-widget/view-widget.component';
import {FormsModule, ReactiveFormsModule} from '@angular/forms';
import {MatInputModule} from '@angular/material/input';
import {AuthInterceptor} from '@shared/auth-services/auth.interceptor';
import { FormsModule, ReactiveFormsModule } from '@angular/forms';
import { MatInputModule } from '@angular/material/input';
import { AuthInterceptor } from '@shared/auth-services/auth.interceptor';
import { HTTP_INTERCEPTORS } from '@angular/common/http';
import { ToolbarComponent } from '@shared/toolbar/toolbar.component';
import { ChartsModule } from 'ng2-charts';
import {MatTooltipModule} from '@angular/material/tooltip';
import { WidgetPreferencesComponent } from './logbook/widgets/widget-preferences/widget-preferences.component';
import { MatTooltipModule } from '@angular/material/tooltip';
import { WidgetPreferencesComponent } from './logbook/widgets/widget-preferences/widget-preferences.component';
import { MatSelectModule } from '@angular/material/select';
import {MatRadioModule} from '@angular/material/radio';
import {MatCheckboxModule} from '@angular/material/checkbox';
import { MatRadioModule } from '@angular/material/radio';
import { MatCheckboxModule } from '@angular/material/checkbox';
import { SettingsComponent } from '@shared/settings/settings.component';
import { CollectionWidgetComponent } from './overview/collection-widget/collection-widget.component';
import { CollectionWidgetComponent } from './overview/collection-widget/collection-widget.component';
import { AuthService } from '@shared/auth-services/auth.service';
import { Router } from '@angular/router';
import { AddLogbookComponent } from './overview/add-logbook/add-logbook.component';
import { AddCollectionComponent } from './overview/add-collection/add-collection.component';
import {MatSlideToggleModule} from '@angular/material/slide-toggle';
import {MatAutocompleteModule} from '@angular/material/autocomplete';
import { MatSlideToggleModule } from '@angular/material/slide-toggle';
import { MatAutocompleteModule } from '@angular/material/autocomplete';
import { LogbookSearchPipe } from './overview/logbook-search.pipe';
import { NavigationButtonComponent } from './logbook/navigation-button/navigation-button.component';
import { NavigationButtonComponent } from './logbook/navigation-button/navigation-button.component';
import { AngularResizeEventModule } from 'angular-resize-event';
import { SnippetContentComponent } from '@shared/snippet/snippet-content/snippet-content.component';
import {CookieService} from 'ngx-cookie-service';
import { CookieService } from 'ngx-cookie-service';
import { NgxJdenticonModule, JDENTICON_CONFIG } from 'ngx-jdenticon';
import { SnippetViewerComponent } from './logbook/widgets/snippet-viewer/snippet-viewer.component';
import { SnippetDashboardNameComponent } from '@shared/snippet/snippet-dashboard-name/snippet-dashboard-name.component';
import { ViewSettingsComponent } from '@shared/settings/view-settings/view-settings.component';
import { ProfileSettingsComponent } from '@shared/settings/profile-settings/profile-settings.component';
import { ViewEditComponent } from '@shared/settings/view-settings/view-edit/view-edit.component';
import {MatTabsModule} from '@angular/material/tabs';
import { MatTabsModule } from '@angular/material/tabs';
import { TagEditorComponent } from '@shared/tag-editor/tag-editor.component';
import { SnippetInfoComponent } from '@shared/snippet/snippet-info/snippet-info.component';
import { SnippetInfoSectionComponent } from '@shared/snippet/snippet-info/snippet-info-section/snippet-info-section.component';
import { SnippetInfoSectionComponent } from '@shared/snippet/snippet-info/snippet-info-section/snippet-info-section.component';
import { UiScrollModule } from 'ngx-ui-scroll';
import { HotkeysComponent } from '@shared/hotkeys/hotkeys.component';
import { ExportDialogComponent } from './logbook/dashboard/dashboard-item/export-dialog/export-dialog.component';
import {MatProgressBarModule} from '@angular/material/progress-bar';
import {MatSnackBarModule} from '@angular/material/snack-bar';
import { MatProgressBarModule } from '@angular/material/progress-bar';
import { MatSnackBarModule } from '@angular/material/snack-bar';
import { DownloadComponent } from '@shared/download/download.component';
import { SearchComponent } from '@shared/search/search.component';
import { SearchWindowComponent } from '@shared/search-window/search-window.component';
import { AppConfigService } from "./app-config.service";
import { NavigationGuardService } from './logbook/core/navigation-guard-service';
import { TaskComponent } from './logbook/core/task/task.component';

const appConfigInitializerFn = (appConfig: AppConfigService) => {
return () => appConfig.loadAppConfig();
return () => appConfig.loadAppConfig();
};

@NgModule({
Expand Down Expand Up @@ -127,6 +128,7 @@ const appConfigInitializerFn = (appConfig: AppConfigService) => {
DownloadComponent,
SearchComponent,
SearchWindowComponent,
TaskComponent
],
imports: [
BrowserModule,
Expand Down
24 changes: 24 additions & 0 deletions scilog/src/app/logbook/core/task/task.component.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<div>
<mat-card class="task-mat-card">
<mat-card-content class="task-content">
<mat-checkbox (change)="toggleTaskIsDone()" [checked]="task.isDone"
[disabled]="isActionAllowed.tooltips.update" matTooltip="{{ isActionAllowed.tooltips.update }}">
<div>

</div>
</mat-checkbox>
<span
[ngStyle]="{'text-decoration': task.isDone? 'line-through' : 'none', 'opacity': task.isDone? '0.6' : '1'}"
class='task-text'>
{{ task.content }}
</span>
<span class="flexExpand"></span>
<span>
<button mat-icon-button (click)="deleteTask()" [disabled]="isActionAllowed.tooltips.delete"
matTooltip="{{ isActionAllowed.tooltips.delete }}">
<mat-icon>delete</mat-icon>
</button>
</span>
</mat-card-content>
</mat-card>
</div>
33 changes: 33 additions & 0 deletions scilog/src/app/logbook/core/task/task.component.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@

.task-mat-card{
margin-bottom: 1px;
margin-left: 20px;
margin-right: 20px;
margin-top: 1px;
min-height: 100%;
text-align: left;
border-radius: 5px;
padding: 4px 0px;
box-shadow: 0 1px 4px 0 rgba(0, 0, 0, .2), 0 2px 8px 0 rgba(0, 0, 0, .14), 0 4px 8px -1px rgba(0, 0, 0, .12);
// background-color: var(--sidenav-color);
color: var(--default-text-color);

}


.task-content{
display: flex;
align-items: center;
max-width: 100%;
padding-left: 15px;
padding-right: 5px;
}

.task-text {
padding-left: 20px;
padding-right: 10px;
}

.flexExpand {
flex: 1 1 auto;
}
68 changes: 68 additions & 0 deletions scilog/src/app/logbook/core/task/task.component.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
import { ComponentFixture, TestBed, waitForAsync } from "@angular/core/testing";
import { TaskComponent } from "./task.component";
import { HttpClientTestingModule } from "@angular/common/http/testing";
import { AppConfigService } from "src/app/app-config.service";
import { Tasks } from "src/app/core/model/tasks";

const getConfig = () => ({});

describe('TaskComponent', () => {
let component: TaskComponent;
let fixture: ComponentFixture<TaskComponent>;

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [HttpClientTestingModule],
providers: [
{ provide: AppConfigService, useValue: { getConfig } },
],
declarations: [TaskComponent]
})
.compileComponents();
}));

beforeEach(() => {
fixture = TestBed.createComponent(TaskComponent);
component = fixture.componentInstance;
component.task = {isDone: false, id: '123'} as Tasks;
fixture.detectChanges();
});

it('should create', () => {
expect(component).toBeTruthy();
});

it('should addTask', () => {
const addTaskSpy = spyOn(component['tasksService'], 'addTask');
const task = {isDone: false} as Tasks;
component.addTask(task);
expect(addTaskSpy).toHaveBeenCalledOnceWith(task);
});

it('should toggleTaskIsDone', () => {
const updateTaskSpy = spyOn(component['tasksService'], 'updateTask');
component.toggleTaskIsDone();
expect(updateTaskSpy).toHaveBeenCalledOnceWith({isDone: true}, '123');
});

it('should deleteTask', () => {
const deleteTaskSpy = spyOn(component['tasksService'], 'deleteTask');
component.deleteTask();
expect(deleteTaskSpy).toHaveBeenCalledOnceWith('123');
});

it('should deleteTask', () => {
const deleteTaskSpy = spyOn(component['tasksService'], 'deleteTask');
component.deleteTask();
expect(deleteTaskSpy).toHaveBeenCalledOnceWith('123');
});

it('should isAllowed', () => {
const canUpdateSpy = spyOn(component['isActionAllowed'], 'canUpdate');
const canDeleteSpy = spyOn(component['isActionAllowed'], 'canDelete');
component.isAllowed();
expect(canUpdateSpy).toHaveBeenCalledTimes(1);
expect(canDeleteSpy).toHaveBeenCalledTimes(1);
});

});
49 changes: 49 additions & 0 deletions scilog/src/app/logbook/core/task/task.component.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
import { Component, Input, OnInit } from '@angular/core';
import { Tasks } from '@model/tasks';
import { TasksService } from '@shared/tasks.service';
import { IsAllowedService } from 'src/app/overview/is-allowed.service';

@Component({
selector: 'task',
templateUrl: './task.component.html',
styleUrls: ['./task.component.scss'],
providers: [IsAllowedService],
})
export class TaskComponent implements OnInit {

@Input()
task: Tasks;

constructor(
private tasksService: TasksService,
protected isActionAllowed: IsAllowedService) {
console.log("constructor called")
}

ngOnInit(): void {
this.isActionAllowed.snippet = this.task;
this.isAllowed();
}

addTask(task: Tasks) {
this.tasksService.addTask(task);
}

toggleTaskIsDone() {
let payload = {
isDone: !this.task.isDone
}
this.tasksService.updateTask(payload, this.task.id);
}

deleteTask() {
console.log("deleting task");
this.tasksService.deleteTask(this.task.id);
}

isAllowed() {
this.isActionAllowed.canDelete();
this.isActionAllowed.canUpdate();
}

}
50 changes: 4 additions & 46 deletions scilog/src/app/logbook/widgets/todos/todos.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,53 +3,11 @@
<span><strong>{{numTasks}}</strong> {{tasks.length == 1 ? 'item' : 'items'}} left</span>
</div>
<mat-form-field class="add-task">
<input matInput class="new-task" placeholder="Add task" autofocus="" (keydown.shift.enter)="addTasks()" (keydown.enter)="addTasks()" [formControl]="newTask">
<input matInput class="new-task" placeholder="Add task" autofocus="" (keydown.shift.enter)="addTasks()" (keydown.enter)="addTasks()" [(ngModel)]="newTask">
</mat-form-field>

<div class="task-container">
<div *ngFor="let task of tasks; let i=index" >
<mat-card class="task-mat-card">
<mat-card-content class="task-content">
<mat-checkbox (change)="toggleTaskIsDone(i)" [checked]="task.isDone">
<div >

</div>
</mat-checkbox>
<span [ngStyle]="{'text-decoration': task.isDone? 'line-through' : 'none', 'opacity': task.isDone? '0.6' : '1'}" class='task-text'>
{{ task.content }}
</span>
<span class="flexExpand"></span>
<span>
<button mat-icon-button (click)="deleteTask(i)">
<mat-icon>delete</mat-icon>
</button>
</span>


</mat-card-content>
</mat-card>
</div>
<div *ngFor="let task of tasks" >
<task [task]="task"></task>
</div>
</div>



<!-- <section class="todoapp">
<header class="header">
<h1>Todos</h1>
<input class="new-todo" placeholder="What needs to be done?" autofocus="" [(ngModel)]="newTodo.title" (keyup.enter)="addTodo()">
</header>
<section class="main" *ngIf="todos.length > 0">
<ul class="todo-list">
<li *ngFor="let todo of todos" [class.completed]="todo.complete">
<div class="view">
<input class="toggle" type="checkbox" (click)="toggleTodoComplete(todo)" [checked]="todo.complete">
<label>{{todo.title}}</label>
<button class="destroy" (click)="removeTodo(todo)"></button>
</div>
</li>
</ul>
</section>
<footer class="footer" *ngIf="todos.length > 0">
<span class="todo-count"><strong>{{todos.length}}</strong> {{todos.length == 1 ? 'item' : 'items'}} left</span>
</footer>
</section> -->
Loading
Loading