Fix migration loop continue statement

paulscherrerinstitute · Mar 15, 2024 · 89957ba · 89957ba
1 parent 64192b8
commit 89957ba
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 6 deletions.
diff --git a/sci-log-db/src/__tests__/acceptance/migrate.acceptance.ts b/sci-log-db/src/__tests__/acceptance/migrate.acceptance.ts
@@ -26,16 +26,33 @@ describe('Migrate', function (this: Suite) {
     await paragraph.execute('Paragraph', 'insertOne', {
       id: '123',
       ownerGroup: 'paragraphAcceptance',
+      textcontent: '<p></p>',
+    });
+    await paragraph.execute('Paragraph', 'insertOne', {
+      id: '456',
+      ownerGroup: 'paragraphAcceptance',
       textcontent: '<p>h &hearts;</p>',
     });
     const sanitizeTextContentStub = sandbox
       .stub(util, 'sanitizeTextContent')
       .callThrough();
     await paragraph.migrateHtmlTexcontent();
-    expect(sanitizeTextContentStub.args[0][0]).to.be.eql('<p>h &hearts;</p>');
-    const modified = await paragraph.execute('Paragraph', 'findOne', {
-      id: '123',
-    });
-    expect(modified.htmlTextcontent).to.be.eql('h ♥');
+    expect(sanitizeTextContentStub.callCount).to.be.eql(2);
+    expect(sanitizeTextContentStub.args[0][0]).to.be.eql('<p></p>');
+    expect(
+      (
+        await paragraph.execute('Paragraph', 'findOne', {
+          id: '123',
+        })
+      ).htmlTextcontent,
+    ).to.be.eql(undefined);
+    expect(sanitizeTextContentStub.args[1][0]).to.be.eql('<p>h &hearts;</p>');
+    expect(
+      (
+        await paragraph.execute('Paragraph', 'findOne', {
+          id: '456',
+        })
+      ).htmlTextcontent,
+    ).to.be.eql('h ♥');
   });
 });
diff --git a/sci-log-db/src/repositories/paragraph.repository.ts b/sci-log-db/src/repositories/paragraph.repository.ts
@@ -30,7 +30,7 @@ export class ParagraphRepository extends SnippetRepositoryMixin<
     const baseSnippetRepository = await this.baseSnippetRepository();
     for await (const paragraph of paragraphsCursor) {
       const sanitised = sanitizeTextContent(paragraph.textcontent);
-      if (!sanitised) return;
+      if (!sanitised) continue;
       await baseSnippetRepository.updateById(
         `${paragraph._id}`,
         {htmlTextcontent: sanitised},