Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bert Example: Add needed vmap to embeddings #608

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Bert Example: Add needed vmap to embeddings #608

merged 1 commit into from
Nov 30, 2023

Conversation

haydn-jones
Copy link
Contributor

Running the Bert example fails with

ValueError: `eqx.nn.Embedding()(x)` should be called with a scalar index `x`. Use `jax.vmap` if you would like to index with multiple values.

just added the vmap in.

@patrick-kidger patrick-kidger merged commit ca995ee into patrick-kidger:main Nov 30, 2023
2 checks passed
@patrick-kidger
Copy link
Owner

patrick-kidger commented Nov 30, 2023

LGTM! Merged - thank you for the fix. :)

(This was changed to be more strict a few releases ago.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants