Merge Bug Fixes #1047
Closed
Merge Bug Fixes #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets the default precision of part parameter searching to femto to maintain fractional values.
This commit adds the part price information to the stock history. The average price of a part doesn't change when stock is depleted
This commit sets the default category to null upon part creation. This is in effort to make the user pick the correct category.
This commit fixes the exporter adding accented characters to the file.
This commit keeps the project remark connected to the newly selected items in a project report.
* populate all form-items with values from selected parameter-record `onParameterSelect(...)` * normalize order of properties (list unit name after id) Signed-off-by: Florian Kerle <[email protected]>
This commit closes issue partkeepr#418. Double clicking on a part-item in a 'Storage Location' opens the part details window.
Do not rely on deprecated the URL.createObjectURL for MediaStream, other than as a fallback for old browsers. Firefox (62+) have deprecated it, Safari have deprecated it, and Chrome have started the process to deprecate this as well. I should note that I have not built this code myself and tested it, but the issue partkeepr#1002 is still present in the demo site and this code here is simply adopted from the developer site of Mozilla. Sources: https://bugs.webkit.org/show_bug.cgi?id=167518 https://bugs.chromium.org/p/chromium/issues/detail?id=800767#c28 https://www.fxsitecompat.com/en-CA/docs/2018/url-createobjecturl-no-longer-accepts-mediastream-as-argument/ https://developer.mozilla.org/sv-SE/docs/Web/API/HTMLMediaElement/srcObject#Supporting_fallback_to_the_src_property
|
Viewing the CI build, I think I know what happened; some files were incorrectly committed. I'm closing this request and pushing a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch applies the following bug fixes;
fixes: #997, #989, #418, #1002
It also fixes exporting issues, allows the root category to not be set as default, fixes prices in stoc history, and fixes a rounding issues in parameter searching.