Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump docker/build-push-action from 5 to 6 #1540

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 7, 2024

Bumps docker/build-push-action from 5 to 6.

Release notes

Sourced from docker/build-push-action's releases.

v6.0.0

[!NOTE] This major release adds support for generating Build summary and exporting build record for your build. You can disable this feature by setting DOCKER_BUILD_NO_SUMMARY: true environment variable in your workflow.

Full Changelog: docker/build-push-action@v5.4.0...v6.0.0

v5.4.0

Full Changelog: docker/build-push-action@v5.3.0...v5.4.0

v5.3.0

Full Changelog: docker/build-push-action@v5.2.0...v5.3.0

v5.2.0

Full Changelog: docker/build-push-action@v5.1.0...v5.2.0

v5.1.0

Full Changelog: docker/build-push-action@v5.0.0...v5.1.0

Commits
  • 4f58ea7 Merge pull request #1234 from docker/dependabot/npm_and_yarn/docker/actions-t...
  • 49b5ea6 chore: update generated content
  • 13c9fdd chore(deps): Bump @​docker/actions-toolkit from 0.38.0 to 0.39.0
  • e44afff Merge pull request #1232 from docker/dependabot/npm_and_yarn/path-to-regexp-6...
  • 67ebad3 chore(deps): Bump path-to-regexp from 6.2.2 to 6.3.0
  • 32945a3 Merge pull request #1230 from docker/dependabot/npm_and_yarn/docker/actions-t...
  • e0fe9cf chore: update generated content
  • 8f1ff6b chore(deps): Bump @​docker/actions-toolkit from 0.37.1 to 0.38.0
  • 5cd11c3 Merge pull request #1211 from crazy-max/summary-info-message
  • 0aba704 chore: update generated content
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5 to 6.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v5...v6)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested review from a team as code owners November 7, 2024 20:13
@dependabot dependabot bot added D0 - Dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Nov 7, 2024
@Imod7
Copy link
Contributor

Imod7 commented Nov 11, 2024

I updated the current PR with this commit which includes the following changes :

Adjust Docker Summary related variables

Context

  • Starting with v6.0.0 of docker/build-push-action, Docker-build summaries are generated and exported by default. To keep the previous behavior, we can set DOCKER_BUILD_NO_SUMMARY to true.
  • From v6.3.0 the previous environment variable was deprecated and now it is recommended to set DOCKER_BUILD_RECORD_UPLOAD and DOCKER_BUILD_SUMMARY to false to avoid uploading summaries.

Docker docs link found here

Sidecar Changes
Right now in Sidecar, I am setting these variables to false for two reasons :

  1. that way we maintain the previous behavior and
  2. currently afaik, we don't have a major need to keep records of Docker builds. If this is needed in the future, we can adjust these variables accordingly.
  3. avoid any possible cluttering in the logs (?)

I am also setting the version of docker/build-push-action specifically to v6.9.0 since it is the latest and it includes the up to date variables mentioned in v6.3.0.

Minor Fix in Dockerfile

When running yarn build:docker the following warning appears:

WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)

This is fixed by making upper case the as keyword (source).

@Imod7 Imod7 merged commit f7465da into master Nov 11, 2024
13 of 14 checks passed
@Imod7 Imod7 deleted the dependabot/github_actions/docker/build-push-action-6 branch November 11, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0 - Dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants