Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: how to access router in getRoutes #1510

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: how to access router in getRoutes #1510

merged 1 commit into from
Oct 10, 2024

Conversation

Imod7
Copy link
Contributor

@Imod7 Imod7 commented Oct 10, 2024

Description

Rel #1508

Due to the upgrade in Express 5, we need to adjust how the router is accessed.

Test

Run Sidecar from the latest release and check

http://127.0.0.1:8080

in your browser or with curl from your terminal

@Imod7 Imod7 requested a review from a team as a code owner October 10, 2024 10:04
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a Asset Hub public endpoint, everything works as expected.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Imod7 Imod7 merged commit f0d662b into master Oct 10, 2024
15 checks passed
@Imod7 Imod7 deleted the domi-fix-routes branch October 10, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants