test: add test for fee-estimate fix #1506
Conversation
| @@ -71,6 +105,17 @@ describe('TransactionFeeEstimateService', () => { | |||
| ).toStrictEqual(validRuntimeResponse); | |||
| }); | |||
|
|
|||
| it('Works with a valid transaction at block 22887036', async () => { | |||
There was a problem hiding this comment.
transactionPaymentApi.queryInfo doesn't care of the block number, it is always queried against the current runtime version. So being strict, we don't need here the detail at what block it should work.
There was a problem hiding this comment.
Thank you for this very good point!
In production environment, yes you are absolutely right, the transactionPaymentApi.queryInfo call will work against the finalized block (related line of code here). However in the test environment, I cannot (and I should not) query the live chain and get the finalized block. That is why I need to specify a block height manually and pass it as an argument which is what happens here.
Manually setting all these different parameters in tests is expected because we want to have control of the setting in which the tests are run. That is why we mock everything (or what we need) and we can simulate being at a specific block height using that specific type registry and metadata, while also mocking the expected response.
Description
Adds a test that covers the case related to the recent fix (#1505) in the
fee-estimateendpoint. The test is mocked at block22887036and with Polkadot registryv1003000.How to test
Run
yarn testoryarn test transactionFeeEstimateServiceand all tests should pass.