fix(calc): remove wasm-pack from node, and add it to calc library #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bee344
approved these changes
Nov 22, 2023
Imod7
reviewed
Nov 22, 2023
Co-authored-by: Dominique <[email protected]>
Imod7
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1259
This PR removes the wasm-pack package from node, and adds it into the script for building calc. It will ask if the user wants to download it globally in order to build. It wont add anything to your system without your explicit permission.
This had to be done because wasm-pack was giving issues for building docker images using:
docker build --platform linux/arm/v8 -t substrate-api-sidecar .