-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add first and last aggregations to Rolling and Expanding #60579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting this @snitish.
Curious if we even need a Cython function for this? It seems we can replicate this with a take
on the original data accounting for min_periods
/window
size
@mroeschke would |
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
bumping this for visibility. |
Some quick benchmarks I ran:
|
Sorry for the delay @snitish. Thanks for sticking with this |
No problem at all. Thanks for approving! |
doc/source/whatsnew/v3.0.0.rst
file if fixing a bug or adding a new feature.