Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix path to experimental pack binaries #211

Merged
merged 4 commits into from
Apr 4, 2024
Merged

fix path to experimental pack binaries #211

merged 4 commits into from
Apr 4, 2024

Conversation

sophiewigmore
Copy link
Member

Summary

The latest version of skopeo on Ubuntu 22.04 isn't up-to-date enough to have multi-arch push support, so use crane instead

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@sophiewigmore sophiewigmore requested a review from a team as a code owner April 3, 2024 21:04
mhdawson
mhdawson approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophiewigmore sophiewigmore enabled auto-merge (squash) April 4, 2024 14:16
@sophiewigmore sophiewigmore merged commit 5c2b251 into main Apr 4, 2024
6 checks passed
@sophiewigmore sophiewigmore deleted the fix-push-image branch April 4, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophiewigmore @mhdawson