Puck.js: Fix Puck.selfTest() regression

pajusmar · May 22, 2024 · eaa0674 · eaa0674
1 parent fdbf0bf
commit eaa0674
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -54,6 +54,7 @@
             Bangle.js1: Fix issue where going out of and back into a menu would cause 'Back' to be added twice (fix #2470)
             Bangle.js2: Added Graphics.filter (to allow gaussian/etc filters to be applied to graphics instances for borders/blur)
             Graphics.drawImages layer x/y can now be non-integer (smoother movement on scaled/rotated images)
+            Puck.js: Fix Puck.selfTest() regression
 
      2v21 : nRF52: free up 800b more flash by removing vector table padding
             Throw Exception when a Promise tries to resolve with another Promise (#2450)

diff --git a/libs/puckjs/jswrap_puck.c b/libs/puckjs/jswrap_puck.c
@@ -1438,7 +1438,7 @@ If the self test fails, it'll set the Puck.js Bluetooth advertising name to
 JsVarFloat _jswrap_puck_selfTest_led(Pin pin) {
   jshPinSetState(pin, JSHPINSTATE_GPIO_IN_PULLUP);
   nrf_delay_ms(1);
-  JsVarFloat v = jshPinAnalog(LED1_PININDEX);
+  JsVarFloat v = jshPinAnalog(pin);
   jshPinSetState(pin, JSHPINSTATE_GPIO_IN);
   return v;
 }