Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ghcr images need to publish to pact-foundation / dockerhub images to pactfoundation #175

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Feb 26, 2024

GitHub container registries must contain a matching NAMESPACE to the GitHub user or org.

This worked on my personal fork, as my GH and Docker username are the same, however pact-foundation uses a hyphen-less NAMESPACE when publishing to docker.io

https://hub.docker.com/u/pactfoundation

We therefore need to set the org name to pact-foundation when publishing to ghcr.

…s to pactfoundation

GitHub container registries must contain a matching NAMESPACE to the GitHub user or org.

This worked on my personal fork, as my GH and Docker username are the same, however pact-foundation uses a hyphen-less NAMESPACE when publishing to docker.io

https://hub.docker.com/u/pactfoundation

We therefore need to set the org name to pact-foundation when publishing to ghcr.
@YOU54F YOU54F force-pushed the fix/ghcr_update_namespace branch 2 times, most recently from bcbf73f to b5c33df Compare February 26, 2024 16:59
@YOU54F YOU54F force-pushed the fix/ghcr_update_namespace branch from b5c33df to f0acc31 Compare February 26, 2024 17:00
@YOU54F YOU54F merged commit 9e16bcb into master Feb 26, 2024
6 checks passed
@YOU54F YOU54F deleted the fix/ghcr_update_namespace branch May 20, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant