[Enhancement][Cherry-Pick][Branch-3.1] Add unkown file format in scan…

… range (StarRocks#33147) Signed-off-by: Smith Cruise <[email protected]> (cherry picked from commit 39c9e43)
packy92 · Oct 19, 2023 · 2644838 · 2644838
1 parent 77821ab
commit 2644838
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 9 deletions.
diff --git a/fe/fe-core/src/main/java/com/starrocks/connector/hive/RemoteFileInputFormat.java b/fe/fe-core/src/main/java/com/starrocks/connector/hive/RemoteFileInputFormat.java
@@ -55,8 +55,7 @@ public THdfsFileFormat toThrift() {
             case TEXT:
                 return THdfsFileFormat.TEXT;
             default:
-                break;
+                return THdfsFileFormat.UNKNOWN;
         }
-        return null;
     }
 }
diff --git a/fe/fe-core/src/test/java/com/starrocks/connector/hive/RemoteFileInputFormatTest.java b/fe/fe-core/src/test/java/com/starrocks/connector/hive/RemoteFileInputFormatTest.java
@@ -16,6 +16,7 @@
 package com.starrocks.connector.hive;
 
 import com.starrocks.connector.hive.RemoteFileInputFormat;
+import com.starrocks.thrift.THdfsFileFormat;
 import org.junit.Assert;
 import org.junit.Test;
 
@@ -27,4 +28,10 @@ public void testParquetFormat() {
         Assert.assertSame(RemoteFileInputFormat.ORC,
                 RemoteFileInputFormat.fromHdfsInputFormatClass("org.apache.hadoop.hive.ql.io.orc.OrcInputFormat"));
     }
+
+    @Test
+    public void testUnknownFormat() {
+        RemoteFileInputFormat format = RemoteFileInputFormat.UNKNOWN;
+        Assert.assertEquals(THdfsFileFormat.UNKNOWN, format.toThrift());
+    }
 }
diff --git a/gensrc/thrift/Descriptors.thrift b/gensrc/thrift/Descriptors.thrift
@@ -60,13 +60,15 @@ struct TTupleDescriptor {
 }
 
 enum THdfsFileFormat {
-  TEXT,
-  LZO_TEXT,
-  RC_FILE,
-  SEQUENCE_FILE,
-  AVRO,
-  PARQUET,
-  ORC,
+  TEXT = 0,
+  LZO_TEXT = 1,
+  RC_FILE = 2,
+  SEQUENCE_FILE = 3,
+  AVRO = 4,
+  PARQUET = 5,
+  ORC = 6,
+
+  UNKNOWN = 100
 }