Fixes related with packit service slowliness #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed. ✔️ pre-commit SUCCESS in 2m 33s |
mfocko
approved these changes
Oct 1, 2024
majamassarini
force-pushed
the
fix/packit-service/2512
branch
from
3c988a7 to
f7a03b1
Compare
lbarcziova
approved these changes
Oct 2, 2024
|
Build failed. ✔️ pre-commit SUCCESS in 2m 28s |
This commit is meant to fix point 5. on analysis at https://gist.github.com/majamassarini/85033b59607a3f3da570cf5aaf2b8c7a raise_on_status (in urllib3.Retry) meaning is: Similar meaning to raise_on_redirect: whether we should raise an exception, or return a response, if status falls in status_forcelist range and retries have been exhausted. I would force to have or a result or an exception for not making Celery task hanging.
majamassarini
force-pushed
the
fix/packit-service/2512
branch
from
f7a03b1 to
f2b5830
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 23s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 23s |
softwarefactory-project-zuul
bot
merged commit 3d0800f
into
packit:main
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should partially fix packit/packit-service#2512