Implement GitProject.get_commits()
#857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikola Forró <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 32s |
mfocko
approved these changes
Sep 6, 2024
| @@ -54,6 +54,7 @@ In case you find any error, please [create a new issue](https://github.com/packi | |||
| | ----------------------------- | :----: | :----: | :---------------------: | | |||
| | `change_token` | ✘ | ✔ | ✔ | | |||
| | `get_release` | ✔ | ✔ | ✘ | | |||
| | `get_commits` | ✔ | ✔ | ✘ | | |||
There was a problem hiding this comment.
Is there something that works on Pagure? (not even push counts, cause even that can yield 500…)
| ref = ref or self.default_branch | ||
| return [ | ||
| commit.id | ||
| for commit in self.gitlab_repo.commits.list(ref_name=ref, all=True) |
There was a problem hiding this comment.
I have a feeling that the list was a not the best decision waaaay back in the old days.
lbarcziova
approved these changes
Sep 7, 2024
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 3m 08s |
softwarefactory-project-zuul
bot
merged commit 358fd86
into
packit:main
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to packit/packit-service#2495.