Unify interface for labels #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 27s |
mfocko
approved these changes
Feb 8, 2024
Comment on lines
+2087
to
+2088
| def __str__(self) -> str: | ||
| return "Issue" + super().__str__() |
There was a problem hiding this comment.
I think that this in combination with the __str__ in the forge-specific classes will create a rather weird string representation, but in the end… it's still just a string, so I think it's fine.
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 33s |
softwarefactory-project-zuul
bot
merged commit f4946d9
into
packit:main
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for packit/packit-service#2334
RELEASE NOTES BEGIN
Interface for labels was unified and
labelsproperty for PullRequest and Issue now return list of PRLabel and IssueLabel respectively.RELEASE NOTES END