Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab list MRs: return all, not just 20 #819

Merged
merged 3 commits into from
Oct 27, 2023
Merged

gitlab list MRs: return all, not just 20 #819

merged 3 commits into from
Oct 27, 2023

Conversation

TomasTomecek
Copy link
Member

@TomasTomecek TomasTomecek commented Oct 19, 2023 •
edited
Loading

TODO:

  • requre

python-gitlab==3.14.0

Calling a `list()` method without specifying `get_all=True` or
`iterator=True` will return a maximum of 20 items. Your query returned
20 of 87 items.

RELEASE NOTES BEGIN
Fixed an issue where getting a list of GitLab merge requests using .list() would return only 20 items.
RELEASE NOTES END

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5f4e16f5add342b5a7d27f1eefa219a7

✔️ pre-commit SUCCESS in 2m 03s
✔️ ogr-tests-pip-deps SUCCESS in 10m 39s

lachmanfrantisek
lachmanfrantisek reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised this isn't covered by any test. Also, I have a deja vu we've hit and fixed this somewhere already..;)

@TomasTomecek
Copy link
Member Author

I couldn't reproduce the CI failure locally with requre, let's see

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/44a4a97164464df6965e68ce010abd77

✔️ pre-commit SUCCESS in 1m 59s
❌ ogr-tests-pip-deps FAILURE in 10m 57s

@TomasTomecek
Copy link
Member Author

TomasTomecek commented Oct 25, 2023 •
edited
Loading

There is a change in how GitLab calls .list() in F37 and the rest.

Well, F37 will be EOL soon, so...

python3-gitlab-3.3.0-3.fc37

python3-gitlab-3.14.0-1.fc38.noarch.
python3-gitlab-3.14.0-4.fc39.noarch

please advise what to do: .skipif(version < 3.14)?

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/049aec0163684a70b9cf16365ad94523

✔️ pre-commit SUCCESS in 2m 04s
✔️ ogr-tests-pip-deps SUCCESS in 11m 31s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ede6f580db5645239419a28d798561b5

✔️ pre-commit SUCCESS in 1m 57s
❌ ogr-tests-pip-deps FAILURE in 10m 35s

@TomasTomecek TomasTomecek added the discuss discuss To be discussed within a team (usually on the so-called Architecture meeting next Thursday) label Oct 26, 2023
@TomasTomecek
gitlab list MRs: return all, not just 20
6a2ae80 
> python-gitlab==3.14.0

```
Calling a `list()` method without specifying `get_all=True` or
`iterator=True` will return a maximum of 20 items. Your query returned
20 of 87 items.
```

Signed-off-by: Tomas Tomecek <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/92c5706178fb41bc878604b0c6a8c3d1

✔️ pre-commit SUCCESS in 3m 15s
✔️ ogr-tests-pip-deps SUCCESS in 10m 34s

@TomasTomecek TomasTomecek requested a review from mfocko October 26, 2023 08:31
@TomasTomecek TomasTomecek removed the discuss discuss To be discussed within a team (usually on the so-called Architecture meeting next Thursday) label Oct 26, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ca5bcea840114436959a2e0d8759c2ed

✔️ pre-commit SUCCESS in 16m 43s
✔️ ogr-tests-pip-deps SUCCESS in 10m 33s

@TomasTomecek TomasTomecek added the mergeit When set, zuul wil gate and merge the PR. label Oct 26, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/3bd36dc48f934e00add8a8e26242c6de

✔️ pre-commit SUCCESS in 1m 57s
✔️ ogr-tests-pip-deps SUCCESS in 10m 31s

@TomasTomecek
test_mr_list_limit: skip on old python-gitlab
79f2497 
@mfocko wasn't able to reproduce locally what we experience in CI

since this involves old python-gitlab that soon will be unsupported,
let's skip it in the meantime

Signed-off-by: Tomas Tomecek <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/8b7899ff87164bb5a372ec206473de23

✔️ pre-commit SUCCESS in 2m 20s
✔️ ogr-tests-pip-deps SUCCESS in 11m 49s

@lachmanfrantisek
Copy link
Member

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/8448de50c8ed4233a13787b5ea66a301

✔️ pre-commit SUCCESS in 1m 58s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a2005ed into packit:main Oct 27, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachmanfrantisek lachmanfrantisek lachmanfrantisek left review comments

@mfocko mfocko mfocko approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomasTomecek @lachmanfrantisek @mfocko