Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused files from testdata #5079

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

jafingerhut
Copy link
Contributor

All of the files removed by this commit appear never to be used during p4c test runs. Some details about each removed file and why it is still in the repository are given below.

  • p4_14_samples_outputs/wide_action2-midend.p4

The other files with names beginning "wide_action2" were removed with this commit in 2019. It appears that the one remaining one was not removed then, as it should have been.

commit ae6fb22
Author: Mihai Budiu [email protected]
Date: Thu Apr 25 16:46:31 2019 -0700

  • p4_16_dpdk_errors_outputs/pna-dpdk-large-constants.p4-error
  • p4_16_dpdk_errors_outputs/pna-dpdk-large-constants.p4.bfrt.json

Other files with a similar name were modifed, or moved from directory p4_16_dpdk_errors_outputs to directory p4_16_samples_output, with this commit. The two files above appear to have been forgotten to be removed.

commit 4005380 (HEAD -> main, origin/main, origin/ HEAD)
Author: maheswari-s [email protected]
Date: Mon Dec 23 22:41:14 2024 +0530

  • p4_16_errors/constructor3_e.s

It was first added in this commit:

commit 6b9da23
Author: Mihai Budiu [email protected]
Date: Mon Nov 23 11:58:14 2020 -0800

which appears to have been a mistake.

  • p4tc_samples_outputs/default_action_example_parser.o

This is an ELF format binary file, which appears to have been committed by accident in this commit.

commit 9005729
Author: Komal Jain [email protected]
Date: Wed Nov 29 16:34:20 2023 +0530

  • p4_16_errors_outputs/issue1777-bmv2.p4.entries.txt
  • p4_16_errors_outputs/issue1803_same_table_name.p4.entries.txt
  • p4_16_errors_outputs/issue-2123_e.p4.entries.txt
  • p4_16_errors_outputs/issue2283_2-bmv2.p4.entries.txt
  • p4_16_errors_outputs/issue3299.p4.entries.txt
  • p4_16_errors_outputs/issue532.p4.entries.txt
  • p4_16_errors_outputs/table-entries-lpm-2.p4.entries.txt
  • p4_16_errors_outputs/table-entries-optional-2-bmv2.p4.entries.txt
  • p4_16_samples_outputs/fabric_20190420/fabric.p4.entries.txt
  • p4_16_samples_outputs/omec/up4.p4.entries.txt
  • p4_16_samples_outputs/pins/pins_fabric.p4.entries.txt
  • p4_16_samples_outputs/pins/pins_middleblock.p4.entries.txt
  • p4_16_samples_outputs/pins/pins_wbb.p4.entries.txt

All of the files above have another file in the repo with a file name suffix of .txtpb, and the commit below that added many other .txtpb files and removed the corresponding .txt files neglected to remove the files above.

commit 5082fe3
Author: Fabian Ruffy [email protected]
Date: Wed Jan 24 18:31:00 2024 +0100

All of the files removed by this commit appear never to be used during
p4c test runs.  Some details about each removed file and why it is
still in the repository are given below.

+ p4_14_samples_outputs/wide_action2-midend.p4

The other files with names beginning "wide_action2" were removed with
this commit in 2019.  It appears that the one remaining one was not
removed then, as it should have been.

commit ae6fb22
Author: Mihai Budiu <[email protected]>
Date:   Thu Apr 25 16:46:31 2019 -0700

+ p4_16_dpdk_errors_outputs/pna-dpdk-large-constants.p4-error
+ p4_16_dpdk_errors_outputs/pna-dpdk-large-constants.p4.bfrt.json

Other files with a similar name were modifed, or moved from directory
p4_16_dpdk_errors_outputs to directory p4_16_samples_output, with this
commit.  The two files above appear to have been forgotten to be
removed.

commit 4005380 (HEAD -> main, origin/main, origin/
HEAD)
Author: maheswari-s <[email protected]>
Date:   Mon Dec 23 22:41:14 2024 +0530

+ p4_16_errors/constructor3_e.s

It was first added in this commit:

commit 6b9da23
Author: Mihai Budiu <[email protected]>
Date:   Mon Nov 23 11:58:14 2020 -0800

which appears to have been a mistake.

+ p4tc_samples_outputs/default_action_example_parser.o

This is an ELF format binary file, which appears to have been
committed by accident in this commit.

commit 9005729
Author: Komal Jain <[email protected]>
Date:   Wed Nov 29 16:34:20 2023 +0530

+ p4_16_errors_outputs/issue1777-bmv2.p4.entries.txt
+ p4_16_errors_outputs/issue1803_same_table_name.p4.entries.txt
+ p4_16_errors_outputs/issue-2123_e.p4.entries.txt
+ p4_16_errors_outputs/issue2283_2-bmv2.p4.entries.txt
+ p4_16_errors_outputs/issue3299.p4.entries.txt
+ p4_16_errors_outputs/issue532.p4.entries.txt
+ p4_16_errors_outputs/table-entries-lpm-2.p4.entries.txt
+ p4_16_errors_outputs/table-entries-optional-2-bmv2.p4.entries.txt
+ p4_16_samples_outputs/fabric_20190420/fabric.p4.entries.txt
+ p4_16_samples_outputs/omec/up4.p4.entries.txt
+ p4_16_samples_outputs/pins/pins_fabric.p4.entries.txt
+ p4_16_samples_outputs/pins/pins_middleblock.p4.entries.txt
+ p4_16_samples_outputs/pins/pins_wbb.p4.entries.txt

All of the files above have another file in the repo with a file name
suffix of `.txtpb`, and the commit below that added many other
`.txtpb` files and removed the corresponding `.txt` files neglected to
remove the files above.

commit 5082fe3
Author: Fabian Ruffy <[email protected]>
Date:   Wed Jan 24 18:31:00 2024 +0100

Signed-off-by: Andy Fingerhut <[email protected]>
@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Dec 31, 2024
@jafingerhut jafingerhut added this pull request to the merge queue Dec 31, 2024
Merged via the queue into p4lang:main with commit 1dc0afa Dec 31, 2024
20 checks passed
@jafingerhut jafingerhut deleted the remove-unused-testdata-files branch December 31, 2024 14:08
AdarshRawat1 pushed a commit to AdarshRawat1/p4c that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants