Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bf-asm command line option in addition to environment variables. #5070

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Dec 17, 2024

@pkotikal Can you try whether this option works. I do not have a machine with the studio available currently.

@fruffy fruffy added the tofino Topics related to the Tofino switch and back end. label Dec 17, 2024
@fruffy fruffy requested a review from pkotikal December 17, 2024 13:15
@pkotikal
Copy link
Contributor

@pkotikal Can you try whether this option works. I do not have a machine with the studio available currently.

Sure

Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The proof is in the build & successful test pudding, of course, but I'm betting this is getting us closer.

@fruffy fruffy added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit bed75a8 Dec 18, 2024
19 checks passed
@fruffy fruffy deleted the fruffy/bf-asm-arg branch December 18, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tofino Topics related to the Tofino switch and back end.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants