Ignore typeless structs in unstructured annotations

[ChrisDodd]

This pass expects struct expressions in unstructured annotations to have explicit types. Using { } in unstructured annotation is actually allowed by the language spec, it does not make sense for the frontend to prevent this (in fact any sequence of tokens can be used as long as parentheses are balanced).

[asl]

Is there any test for this fix?

[ChrisDodd]

Is there any test for this fix?

Actually testing this requires a backend that has an annotation that contains this form (an untyped brace-enclose kv-list as an expression within an unstructured annotation) and has an appropriate PARSE_X to get it parsed. If you just use the p4test backend, all unstructured annotations remain unparsed.

We could add some annotation parsers to p4test -- somthing like PARSE_EXPRESSION_LIST("expr_list") would allow writing testcases that have @expr_list( ..some expressions.. ) and would test all the various paths for parsed unstructured annotations. Just on general principles, we should add an annotation for every generic PARSE_X macro defined in the common code and write some testcases that excercise them.

[asl]

Actually testing this requires a backend that has an annotation that contains this form (an untyped brace-enclose kv-list as an expression within an unstructured annotation) and has an appropriate PARSE_X to get it parsed. If you just use the p4test backend, all unstructured annotations remain unparsed.

Ah right. Completely forgot that it's only end-to-end testing that is available...