Introduce the SKB metadata extern #4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@komaljai please take a look when you have some time |
vbnogueira
force-pushed
the
skb_meta
branch
4 times, most recently
from
60d30af to
5e1e5f0
Compare
fruffy
added
p4tc
komaljai
reviewed
Oct 3, 2024
|
You can try to inherit EBPF class DeparserBodyTranslatorPSA in TC and make related changes in TC backend. |
|
Could you add example for skb metadata extern? |
I added the example in this commit 96707ea and rebased |
vbnogueira
force-pushed
the
skb_meta
branch
4 times, most recently
from
da95c99 to
e44e743
Compare
Done |
komaljai
approved these changes
Oct 17, 2024
auto-merge was automatically disabled
October 17, 2024 15:12
Head branch was pushed to by a user without write access
|
Tested with other examples we had and saw that this PR breaks one of our examples |
vbnogueira
force-pushed
the
skb_meta
branch
2 times, most recently
from
7a177fa to
651dd08
Compare
vbnogueira
force-pushed
the
skb_meta
branch
4 times, most recently
from
d73b5ff to
dbc19dc
Compare
|
@komaljai please take another look when you have some time |
komaljai
reviewed
Dec 12, 2024
komaljai
approved these changes
Dec 12, 2024
Signed-off-by: Mouse <[email protected]>
Since we are not relying on recirculation to reset the skb protocol to the original value anymore, only recirculate if needed Signed-off-by: Mouse <[email protected]>
Signed-off-by: Mouse <[email protected]>
Signed-off-by: Mouse <[email protected]>
Signed-off-by: Mouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding the SKB metadata extern to the tc backend's control blocks and deparser definitions
The main difference from the previous version is that we dropped the extern representation of the
skb(
tc_skb_metadata), and made skb read/write operation into extern functions.So, for example, to set the skb protocol, the user should do the following:
And to retrive the skb protocol: