Upadate the README with instructions for installing gRPC #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DScano <[email protected]>
jafingerhut
approved these changes
Aug 25, 2024
antoninbas
reviewed
Aug 26, 2024
README.md
Outdated
| -DgRPC_BUILD_TESTS=OFF \ | ||
| -DgRPC_SSL_PROVIDER=package \ | ||
| ../.. | ||
| make -j4 install |
There was a problem hiding this comment.
I would guess that typically you will need to sudo to be able to install in a system location, so maybe decouple the build and install steps to be consistent with other instructions?
Signed-off-by: DScano <[email protected]>
antoninbas
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently attempted to install PI and found that the gRPC installation instructions in the README were outdated. gRPC can now only be installed via Bazel or CMake. The set of commands provided here allowed me to successfully install gRPC and PI with the
./configure --with-proto.