[Reconfigurator] Use per-sled RNGs #7321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested by @sunshowers (#7307 (comment)). This should prevent changes to one sled (e.g., adding a new zone) from perturbing IDs on all subsequent sleds in otherwise-stable tests.
davepacheco
approved these changes
Jan 8, 2025
sunshowers
reviewed
Jan 8, 2025
Comment on lines
+33
to
+36
| // Each sled gets its own set of RNGs to avoid test changes to one sled | ||
| // (e.g., adding an extra zone) perturbing all subsequent zone/dataset/etc. | ||
| // IDs on other sleds. | ||
| sled_rngs: BTreeMap<SledUuid, SledPlannerRng>, |
There was a problem hiding this comment.
Awesome, thanks for this!
sunshowers
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @sunshowers
(#7307 (comment)). This should prevent changes to one sled (e.g., adding a new zone) from perturbing IDs on all subsequent sleds in otherwise-stable tests. (I took a stab at combining this with #7307 and confirmed the diff output is much more reasonable; will update #7307 after this lands.)
The actual code changes here are small and mostly-mechanical; the changes in
rng.rsare the driver (moving the sled-specific RNGs into a per-sled RNG container and dealing with handing those out keyed by sled ID), and everything else fell out from that. Unfortunately this changes all zone/dataset/NIC/IP UUIDs in expectorate tests, so the diff volume is... quite large.