fix: run MySQL 8.1 as a separate container during upgrade from Olive to Redwood #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this because MySQL 8.1 does not have the --mysql-native-password option We have this option turned on for backwards compatibility
Danyal-Faheem
changed the title
Danyal-Faheem
changed the title
Comment on lines
+183
to
+184
| --character-set-server=utf8mb3 | ||
| --collation-server=utf8mb3_general_ci |
There was a problem hiding this comment.
curious: What happens here if someone has already changed the connection strings on their Mysql57?
There was a problem hiding this comment.
I am not sure as I have not tested this out, however, we would want this container to be as similar to the one already being launched in tutor v17. I'm not sure we want to cater to every modification a user might have made.
tutor/commands/upgrade/compose.py
Outdated
Comment on lines
174
to
199
| hooks.Filters.ENV_PATCHES.add_item( | ||
| ( | ||
| "local-docker-compose-services", | ||
| """ | ||
| mysql-8.1: | ||
| extends: mysql | ||
| image: docker.io/mysql:8.1.0 | ||
| command: > | ||
| mysqld | ||
| --character-set-server=utf8mb3 | ||
| --collation-server=utf8mb3_general_ci | ||
| --binlog-expire-logs-seconds=259200 | ||
| """, | ||
| ) | ||
| ) | ||
| hooks.Filters.ENV_PATCHES.add_item( | ||
| ( | ||
| "local-docker-compose-jobs-services", | ||
| """ | ||
| mysql-8.1-job: | ||
| image: docker.io/mysql:8.1.0 | ||
| depends_on: {{ [("mysql-8.1", RUN_MYSQL)]|list_if }} | ||
| """, | ||
| ) | ||
| ) | ||
| hooks.Filters.CONFIG_DEFAULTS.add_item(("MYSQL_HOST", "mysql-8.1")) |
There was a problem hiding this comment.
nit: Can't add_items be used for hooks.Filters.ENV_PATCHES here?
There was a problem hiding this comment.
Updated! Thank you for reminding me.
| tutor_env.save(context.obj.root, config) | ||
| context.invoke(jobs.initialise, limit="mysql") |
There was a problem hiding this comment.
Where is mysql version set to 8.4? Or is it 8.4 already before the code enters MySQL 8.1 context?
There was a problem hiding this comment.
It is already set prior to the context when the user installs tutor v18 onwards.
regisb
reviewed
Oct 18, 2024
regisb
approved these changes
Oct 18, 2024
|
Updated with the changelog entry as well. |
DawoudSheraz
approved these changes
Oct 28, 2024
DawoudSheraz
deleted the
danyalfaheem/run-mysql-8.1-as-separate-container
branch
Danyal-Faheem
added a commit
to edly-io/tutor
that referenced
this pull request
Oct 28, 2024
…to Redwood (overhangio#1140) * ix: run MySQL 8.1 as a separate container during upgrade from Olive to Redwood We do this because MySQL 8.1 does not have the --mysql-native-password option We have this option turned on for backward compatibility
DawoudSheraz
pushed a commit
that referenced
this pull request
Oct 30, 2024
* fix: upgrade MySQL from 5.7 to 8.1 first and then to 8.4 This is required when upgrading from Tutor v15 to v18 directly MySQL does not allow direct upgrades from v5.7 to v8.4 * fix: run MySQL 8.1 as a separate container during upgrade from Olive to Redwood (#1140) We do this because MySQL 8.1 does not have the --mysql-native-password option We have this option turned on for backward compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for the issues brought forward in #1102.
We do this because MySQL 8.1 does not have the
--mysql-native-passwordoption and when upgrading from tutor v15 -> v18, this container would crash as the option does not exist.We have this option turned on for backwards compatibility from tutor v18.1.1 onwards as users who have upgraded all the way from MySQL v5.7 -> v8.4 have their original users created using the mysql_native_password authentication plugin. See #1090 for more details.
After this PR is merged in nightly, we should make a backport to master as well coupled with the changes already made in #1102.