-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds tutor config edit
#1099
feat: adds tutor config edit
#1099
Conversation
@regisb Hi, Thanks for the review comments. I hoped to have addressed them by now. Somehow haven't found the time. I will handle the comments this week. |
I have nothing to add beyond Regis's review--just want to say that this is a great idea and thank you for the contribution 👍🏻 |
ecf0b53
to
853e51e
Compare
853e51e
to
c095e45
Compare
Hi @tecoholic . I'm looking forward to this change! Looks like there are just a couple minor change requests left, and then we're good to merge this. |
@kdmccormick Hi, thanks for the ping. I was waiting on @regisb for more details about read only editor. Can we skip that scenario for now? |
@kdmccormick I am less interested in this feature than you seem to be -- mostly because (IMHO) it doesn't bring anything more than a .bashrc alias. E.g: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patience @tecoholic . If you can rebase and address these comments, I'll be happy to merge this.
c095e45
to
2b00211
Compare
@kdmccormick Thank you for your comments and your patience with this PR. I have addressed your comments to my best. Kindly take another look when you can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry for this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally, works great on Ubuntu! I also commented out the which("open")
block in order to confirm that xdg-open
also works.
In addition to Dawoud's request to add a changelog entry, I have just one more change request and one optional suggestion ⬇️
00565bb
to
d3cd4c0
Compare
@kdmccormick Thank you for the feedback. I added a changelog entry, new options |
changelog.d/20241114_115534_arunmozhi_add_config_edit_command.md
Outdated
Show resolved
Hide resolved
changelog.d/20241114_115534_arunmozhi_add_config_edit_command.md
Outdated
Show resolved
Hide resolved
@DawoudSheraz I have addressed your comments about the docs and updated the PR. |
@kdmccormick Updated the PR with simpler version. P.S: I left a reply to the comment in the review. But, it doesn't show up here. So, adding a note here, just in case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one issue, looks and works great otherwise. Thanks for proposing and working through this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @tecoholic , one last thing: could you change the PR's base to release
and rebase? In order to get improvements out to the biggest set of users, the Tutor convention is to merge to release
if there is nothing breaking, risky, or specific to Open edX's master branches.
Quickly launch the default an editor for editing the config.yml file.
6295887
to
af7d62b
Compare
Co-authored-by: Kyle McCormick <[email protected]>
@kdmccormick Hi, thanks for letting me correct the branch. I couldn't move all the commits and the history with it. So, I just squashed everything and based it on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tecoholic !
Quickly launch the default YAML editor for editing the
config.yml
file.Background
As a developer working with multiple projects, I am constantly changing the tutor config and re-running the
tutor dev launch
to update the devstack. While it is as simple as runningvim $(tutor config printroot)/config.yml
, I often found myself wanting to simply express this better using tutor config edit. So this is an attempt at cross-platform solution doing the same. It might not be the best solution, but something to start with if someone else finds this useful and improves their DevEx.Caveat: I have only tested this on Linux (both open and
xdg-open
works in mine, so it could be said Unix).