Feat: add support for discovery media in minio #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faraz32123
force-pushed
the
feat/add_separate_bucket_for_discovery
branch
from
eca7696 to
0e046e7
Compare
Faraz32123
force-pushed
the
feat/add_separate_bucket_for_discovery
branch
2 times, most recently
from
8d9aa9c to
5f378e4
Compare
DawoudSheraz
reviewed
Jul 3, 2024
changelog.d/20240702_152230_faraz.maqsood_add_separate_bucket_for_discovery.md
Outdated
Show resolved
Hide resolved
DawoudSheraz
reviewed
Jul 3, 2024
Faraz32123
force-pushed
the
feat/add_separate_bucket_for_discovery
branch
2 times, most recently
from
1aa3c98 to
daaa43b
Compare
DawoudSheraz
approved these changes
Jul 9, 2024
|
@regisb Kindly have a look on this. |
regisb
requested changes
Jul 23, 2024
added 2 commits
August 13, 2024 17:50
Run init script for minio to create a bucket for discovery after enabling discovery plugin.
Faraz32123
force-pushed
the
feat/add_separate_bucket_for_discovery
branch
from
5853c81 to
40ef140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Minio's init script will run, it will check if discovery is enabled in the tutor setup. If it's enabled, it'll create it's bucket. I have also added discovery patch which will override course_discovery settings to shift from file storage to minio s3 storage.
close #41.