Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to toolforge build-service #13

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Move to toolforge build-service #13

merged 1 commit into from
Mar 16, 2024

Conversation

david-caro
Copy link
Contributor

This adds:

  • Procfile + web.sh to run the web server
  • http-server module to serve the generated json files
  • Used the $TOOl_DATA_DIR in build.js to generate the files in the right path.
  • Added info in the readme

package.json Outdated Show resolved Hide resolved
@1ec5
Copy link
Member

1ec5 commented Mar 14, 2024

For context, this package isn’t primarily designed to be a MediaWiki bot like the other projects you’ve opened similar PRs against. However, it was being run on a cron job on Toolforge as a lightweight service: #2 (comment). I’m fine with the requested changes and appreciate your help in getting that service back up and running, but the changes need to avoid impacting other environments such as Web applications.

This adds:
* Procfile + web.sh to run the web server
* Aptfiles with python as a dependency to serve static files
* http-server module to serve the generated json files
* Used the $TOOl_DATA_DIR in build.js to generate the files in the
  right path.
* Added info in the readme

Signed-off-by: David Caro <[email protected]>
@Abbe98
Copy link

Abbe98 commented Mar 15, 2024

Feel free to ping me if someone wants access to wmf-sitematrix.toolforge.org. I moved all my projects off Toolforge a while back but I could see why others would like this back on WMF infrastructure.

Copy link
Member

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your consideration and help setting this up!

@Abbe98, I haven’t personally ever used the service on Toolforge, but if you know of anyone who has been, I’d be happy to take ownership of it. My user name there is mxn.

@1ec5 1ec5 merged commit 0a9ba9e into osmlab:main Mar 16, 2024
3 checks passed
@@ -11,7 +11,7 @@ var projects = [
];

var fs = require('fs');
let dataPath = "data";
let dataPath = `${process.env.TOOL_DATA_DIR}/public_html/data`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this at the time, but TOOL_DATA_DIR is normally undefined when running the update script locally. 9d842c6 makes this environment variable optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants