Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external mapcss #2417

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Update external mapcss #2417

merged 1 commit into from
Dec 30, 2024

Conversation

Famlam
Copy link
Collaborator

@Famlam Famlam commented Dec 22, 2024

It fails because one rule has both assertMatch and assertNoMatch for the same tag/key. JOSM only evaluates the last one it encounters, hence doesn't detect it.

I'll wait a few days, maybe they just remove the assertMatch. Otherwise I'll blacklist this rule.
The rule ID for blacklisting: 89219844

https://josm.openstreetmap.de/ticket/24054

JOSM issue was fixed; ready to merge :)

@Famlam Famlam marked this pull request as draft December 22, 2024 19:47
@Famlam Famlam force-pushed the famlam-mapcss-dec24 branch from 9fb032d to 7c16367 Compare December 30, 2024 17:16
@Famlam Famlam force-pushed the famlam-mapcss-dec24 branch from 7c16367 to 9c5427a Compare December 30, 2024 17:18
@Famlam Famlam marked this pull request as ready for review December 30, 2024 17:19
@frodrigo frodrigo merged commit 1ca6f06 into dev Dec 30, 2024
6 checks passed
@Famlam Famlam deleted the famlam-mapcss-dec24 branch December 30, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants