Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emit admin recovery code event #4230

Merged
merged 2 commits into from
Nov 29, 2024
Merged

feat: emit admin recovery code event #4230

merged 2 commits into from
Nov 29, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Nov 28, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

SettingsSucceeded semconv.Event = "SettingsSucceeded"
RecoveryFailed semconv.Event = "RecoveryFailed"
RecoverySucceeded semconv.Event = "RecoverySucceeded"
RecoveryCodeCreatedByAdmin semconv.Event = "RecoveryCodeCreatedByAdmin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe avoid "code" when it is used for both code and link?

Suggested change
RecoveryCodeCreatedByAdmin semconv.Event = "RecoveryCodeCreatedByAdmin"
RecoveryCreatedByAdmin semconv.Event = "RecoveryCreatedByAdmin"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair point.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.59%. Comparing base (d5cfa89) to head (798ff0a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4230      +/-   ##
==========================================
+ Coverage   78.54%   78.59%   +0.04%     
==========================================
  Files         380      380              
  Lines       27266    27282      +16     
==========================================
+ Hits        21417    21442      +25     
+ Misses       4226     4220       -6     
+ Partials     1623     1620       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit a7cdc3a into master Nov 29, 2024
29 checks passed
@aeneasr aeneasr deleted the add-event branch November 29, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants