Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send correct verification status in post-recovery hook #4224

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Nov 26, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr force-pushed the fix-status-recovery branch from b1dfe9d to 1ffb2fc Compare December 2, 2024 10:16
@aeneasr aeneasr force-pushed the fix-status-recovery branch from 1ffb2fc to 6d0b0df Compare December 2, 2024 10:53
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.57%. Comparing base (a7cdc3a) to head (e07c6e4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/strategy/link/strategy_recovery.go 60.00% 1 Missing and 3 partials ⚠️
selfservice/strategy/code/strategy_recovery.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4224   +/-   ##
=======================================
  Coverage   78.56%   78.57%           
=======================================
  Files         380      380           
  Lines       27282    27270   -12     
=======================================
- Hits        21434    21427    -7     
+ Misses       4224     4223    -1     
+ Partials     1624     1620    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 7f50400 into master Dec 3, 2024
28 of 29 checks passed
@aeneasr aeneasr deleted the fix-status-recovery branch December 3, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants