Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce logging in go tests #3562

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Oct 9, 2023

The migration logging is really noisy. This disables it in the go unit/integration tests. Not sure how we can display errors that occur during migration, though.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #3562 (17b26e5) into master (043114b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 17b26e5 differs from pull request most recent head 9bbf4cf. Consider uploading reports for the commit 9bbf4cf to get more accurate results

@@            Coverage Diff             @@
##           master    #3562      +/-   ##
==========================================
- Coverage   78.12%   78.12%   -0.01%     
==========================================
  Files         341      341              
  Lines       22820    22835      +15     
==========================================
+ Hits        17828    17839      +11     
- Misses       3652     3655       +3     
- Partials     1340     1341       +1     
Files Coverage Δ
driver/registry.go 39.02% <100.00%> (+4.81%) ⬆️
driver/registry_default.go 84.59% <100.00%> (ø)
persistence/sql/persister.go 75.86% <100.00%> (+3.04%) ⬆️

... and 2 files with indirect coverage changes

@aeneasr aeneasr merged commit 05de3a2 into master Oct 10, 2023
26 checks passed
@aeneasr aeneasr deleted the jonas-jonas/reduceTestLogging branch October 10, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants