Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eventually consistency API controls #3558

Merged
merged 14 commits into from
Oct 12, 2023
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 6, 2023

Adds a feature used in Ory Network which enables trading faster reads for slightly outdated data.

This feature depends on Cockroach functionality and configuration, and is not possible for MySQL or PostgreSQL.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr force-pushed the eventually-consistent-apis branch from f793689 to ab471ef Compare October 6, 2023 10:13
Adds a feature used in Ory Network which enables trading faster reads for slightly outdated data.

This feature depends on Cockroach functionality and configuration, and is not possible for MySQL or PostgreSQL.
@aeneasr aeneasr force-pushed the eventually-consistent-apis branch from fd82327 to eaf5cb5 Compare October 10, 2023 08:59
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #3558 (1bf737d) into master (e16fed1) will increase coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 86.01%.

❗ Current head 1bf737d differs from pull request most recent head 5e4f1f8. Consider uploading reports for the commit 5e4f1f8 to get more accurate results

@@            Coverage Diff             @@
##           master    #3558      +/-   ##
==========================================
+ Coverage   78.13%   78.15%   +0.01%     
==========================================
  Files         341      341              
  Lines       22923    22967      +44     
==========================================
+ Hits        17912    17950      +38     
- Misses       3664     3669       +5     
- Partials     1347     1348       +1     
Files Coverage Δ
driver/config/config.go 83.33% <100.00%> (+0.04%) ⬆️
identity/test/pool.go 99.57% <100.00%> (+0.01%) ⬆️
selfservice/hook/web_hook.go 79.65% <100.00%> (ø)
selfservice/strategy/oidc/strategy_registration.go 68.32% <100.00%> (ø)
selfservice/strategy/oidc/strategy_login.go 72.22% <90.90%> (ø)
identity/handler.go 84.14% <33.33%> (+0.05%) ⬆️
cmd/daemon/serve.go 87.93% <75.00%> (ø)
persistence/sql/identity/persister_identity.go 81.61% <80.00%> (-0.76%) ⬇️

... and 1 file with indirect coverage changes

@aeneasr aeneasr marked this pull request as ready for review October 11, 2023 21:19
@aeneasr aeneasr merged commit 00cf11c into master Oct 12, 2023
26 checks passed
@aeneasr aeneasr deleted the eventually-consistent-apis branch October 12, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant