added data-testid for Popover and added optional chaining to context …

…passed function
orchestrated-io · Aug 6, 2024 · 0f848ab · 0f848ab
1 parent 95aab77
commit 0f848ab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/components/ActionsMenu/index.js b/lib/components/ActionsMenu/index.js
@@ -148,9 +148,9 @@ export const ActionsMenuHeading = styled((props) => {
   // // Only sets `aria-labelledby` on the Popover root element
   // // if this component is mounted inside it.
   useLayoutEffect(() => {
-    actionMenu.setLabelId(id);
+    actionMenu?.setLabelId?.(id);
 
-    return () => actionMenu.setLabelId(undefined);
+    return () => actionMenu?.setLabelId?.(undefined);
   }, [id, actionMenu]);
 
   return (

diff --git a/lib/components/Popover/index.js b/lib/components/Popover/index.js
@@ -270,6 +270,7 @@ export default function Popover({
   enableSelectAll,
   variant,
   ariaLabel,
+  "data-testid": dataTestId = "popover",
   ...props
 }) {
   const [visible, setVisible] = useState(false);
@@ -303,7 +304,8 @@ export default function Popover({
 
   const triggerProps = {
     ...getReferenceProps({
-      ref: refs.setReference
+      ref: refs.setReference,
+      "data-testid": dataTestId
     })
   };