Following #6439: resolve to use QNames

orbeon · Aug 17, 2024 · f06de2d · f06de2d
1 parent 16b6a24
commit f06de2d
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/form-runner/shared/src/main/scala/org/orbeon/oxf/fr/FormRunnerBaseOps.scala b/form-runner/shared/src/main/scala/org/orbeon/oxf/fr/FormRunnerBaseOps.scala
@@ -443,6 +443,10 @@ trait FormRunnerBaseOps extends FormRunnerPlatform {
   //@XPathFunction
   def showCaptcha: Boolean = isNewOrEditMode(FormRunnerParams().mode) && ! captchaPassed
 
+  // The only reason I see for passing tokens such as `reCAPTCHA` and `SimpleCaptcha` instead of QNames, besides
+  // backward compatibility, is to let things work even if no `xmlns:fr="..."` namespace mapping is present. However,
+  // this is present in the default `properties-local.xml`, so it's generally not an issue.
+  // 2024-08-16: We resolve to use QNames from now on.
   //@XPathFunction
   def captchaComponent(app: String, form: String): Array[String] = {
     val logger                   = Loggers.logger // TODO: Form Runner logger?