spec: Multi-arch image management with ORAS #1514
Conversation
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
FeynmanZhou
requested review from
sajayantony,
shizhMSFT,
SteveLasker,
qweeah and
TerryHowe
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1514 +/- ##
==========================================
- Coverage 85.97% 84.34% -1.63%
==========================================
Files 118 120 +2
Lines 4228 5449 +1221
==========================================
+ Hits 3635 4596 +961
- Misses 354 606 +252
- Partials 239 247 +8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
FeynmanZhou
requested review from
shizhMSFT,
sajayantony,
qweeah and
wangxiaoxuan273
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
| @@ -63,16 +63,15 @@ The proposed CLI commands for managing a multi-arch image are listed below. The | |||
|
|
|||
| - Create a multi-arch image: `oras manifest index create` | |||
| - Update a multi-arch image: `oras manifest index update` | |||
| - Inspect a multi-arch image: `oras manifest fetch`. Add two alias `oras manifest inspect` and `oras manifest show` for usability | |||
| - Add annotations to a multi-arch image: `oras manifest create --annotation` | |||
| - Add annotations to a multi-arch image during creation: `oras manifest index create --annotation` | |||
There was a problem hiding this comment.
nit: do you want to make it a sub-item of "Create a multi-arch image: oras manifest index create"?
There was a problem hiding this comment.
thank you for drawing my attention to this, @FeynmanZhou ! 🙏
some very optional comments below, I hope these helps!
|
|
||
| ### Inspect a multi-arch image | ||
|
|
||
| Add two alias `show` and `inspect`: |
There was a problem hiding this comment.
Can we elaborate more on why this is needed? Is it to inform users the purpose of the command or is it more intuitive for users to input the command?
There was a problem hiding this comment.
Yes. The purpose is to make the inspection operation more intuitive to users. fetch or get is more like download operation to users.
Signed-off-by: Feynman Zhou <[email protected]>
|
Maybe add your svgs to https://github.com/oras-project/oras/blob/main/.github/licenserc.yml#L31 |
What this PR does / why we need it:
Add a spec: Multi-arch image management with ORAS
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1053
Preview: https://github.com/FeynmanZhou/oras/blob/multi-arch/docs/proposals/multi-arch-image-mgmt.md