OKE-29394 Ingress state build failure when ingress reference non-existent ingress class #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Inbaraj-S
commented
Feb 1, 2024
Inbaraj-S
commented
- Added code to skip ingress if no usable ingressclass is found.
oracle-contributor-agreement
bot
added
the
OCA Verified
Pull Request Test Coverage Report for Build 7748677018
💛 - Coveralls |
nirpai
reviewed
Feb 2, 2024
| if ingIc != nil && ingressClass.Name == ingIc.Name && !util.IsIngressDeleting(ing) { | ||
| ingressGroup = append(ingressGroup, ing) | ||
| klog.Errorf("IngressClass not found for ingress: %s. Skipping ingress.", ing.Name) | ||
| } else { |
There was a problem hiding this comment.
You can add a 'continue' in case of error to skip the remaining part of the iteration and remove the else clause?
nirpai
reviewed
Feb 2, 2024
| port: | ||
| number: 100 | ||
| --- | ||
| apiVersion: networking.k8s.io/v1 |
There was a problem hiding this comment.
Thinking this is a sequential processing, can we add ingress 'ingress-state-excluded' in the middle and make sure the last ingress 'ingress-state-new' is processed?
|
Duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.