Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump k8s libs to v0.32.0 #3486

Merged
merged 3 commits into from
Jan 14, 2025
Merged

bump k8s libs to v0.32.0 #3486

merged 3 commits into from
Jan 14, 2025

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented Jan 10, 2025 •
edited
Loading

Description of the change:

Closes #3472
Closes #3470
Closes #3469
Closes #3468

Bumps k8s libs to v0.32.0. In this version, the apiserver speaks protobuf. So, the validatingroundtripper implementation had to be revisited to support it.

Generated code was regenerated for the new libraries with the make gen-all target.

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@perdasilva perdasilva force-pushed the bump/k8s branch 3 times, most recently from d127432 to 8735be1 Compare January 10, 2025 16:19
@perdasilva perdasilva marked this pull request as draft January 10, 2025 17:32
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2025
bump k8s libs
2046f1e 
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the bump/k8s branch 2 times, most recently from 0114d9a to cc4930e Compare January 13, 2025 09:50
@perdasilva perdasilva marked this pull request as ready for review January 13, 2025 09:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@openshift-ci openshift-ci bot requested a review from gallettilance January 13, 2025 09:50
camilamacedo86
camilamacedo86 previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@LalatenduMohanty
Copy link
Member

74a356d is for update generated code. Can you please add more information in the commit about how you updated the generated code. It will be helpful for future when someone trying to figure-out how it was done in the past.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
camilamacedo86
camilamacedo86 previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the points raised are addressed now
It seems great for me

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
update generated code
616897a 
with 'make g'

Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva enabled auto-merge January 14, 2025 15:11
camilamacedo86
camilamacedo86 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@perdasilva perdasilva added this pull request to the merge queue Jan 14, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
Merged via the queue into operator-framework:master with commit 1b6752e Jan 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford left review comments

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@akihikokuroda akihikokuroda Awaiting requested review from akihikokuroda

@dtfranz dtfranz Awaiting requested review from dtfranz

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@camilamacedo86 camilamacedo86

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@perdasilva @LalatenduMohanty @joelanford @camilamacedo86