Add support for Bazel 6 & 7 #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sjain-stanford do you want try this? |
fzakaria
commented
Feb 14, 2024
|
@fzakaria thanks for working on this. I gave it a shot but since we're on slightly older LLVM, couldn't verify the lit tests work (hit build errors). If you've tested it on your end, I say we either land and circle back if I hit issues, or keep this open and I reach out when we do our next integrate (in ~2 weeks). WDYT? |
|
Let's revisit when you integrate to confirm since the purpose of the change is to support your integrate. |
|
Okay I'm back to this as our integrate expectedly fails: Will re-try after cherry-picking this change. |
|
@fzakaria do you mind rebasing this branch on latest HEAD? I'm seeing some merge conflicts that I'm not too familiar resolving: |
1 task
Previous PR openxla#2006 added support for Bazel 7 but some of the changes in Bazel 7 are not backwards compatible with 6. This is a problem for some of our consumers that embed our project in other Bazel workspaces. Specifically, the name of the runfiles directory was changed from the workspace name to be '_main'. The solution adopted here is to use @python_rules and programmatically determine the runfiles directory relative to the lit.cfg.py file.
fzakaria
force-pushed
the
runfiles-follow-up
branch
from
732af01 to
1933fda
Compare
|
@sjain-stanford updated. |
|
@fzakaria confirming the patch works for downstream stablehlo integrations 🎉
Since the llvm lit config setup is pretty much munging paths anyways, I don't have a strong preference one way or another (doing it in lit.cfg.py vs BUILD). Please go with your best judgment here. Once this lands, I will go ahead and bump to stablehlo@HEAD in |
sjain-stanford
approved these changes
Mar 5, 2024
sdasgup3
approved these changes
Mar 5, 2024
sjain-stanford
added a commit
to sjain-stanford/mlir-tcp
that referenced
this pull request
Mar 5, 2024
sjain-stanford
added a commit
to cruise-automation/mlir-tcp
that referenced
this pull request
Mar 6, 2024
[LLVM](https://github.com/llvm/llvm-project/tree/e5ed7b6e2fd368b722b6359556cd0125881e7638) (Feb 27) [StableHlo](https://github.com/openxla/stablehlo/tree/d214e2e2bd568a80a9f25515907b64dd7b98c538) (March 5)** [Torch-MLIR](https://github.com/llvm/torch-mlir/tree/a86e89ecb5c7929a39a38743fb7cacadf1ff41bb) (Mar 4) DONE: - [x] **This is the stablehlo commit right before Bazel 7 (bzlmod) changes landed (openxla/stablehlo#2006) which breaks downstream integrations. Stablehlo devs have kindly provided a fix at openxla/stablehlo#2009 - if it works, I'll revise the stablehlo commit to HEAD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #2006 added support for Bazel 7 but some of the changes in Bazel 7 are not backwards compatible with 6.
This is a problem for some of our consumers that embed our project in other Bazel workspaces.
Specifically, the name of the runfiles directory was changed from the workspace name to be '_main'.
The solution adopted here is to use @python_rules and programmatically determine the runfiles directory relative to the lit.cfg.py file.