Avoid duplicating extra class declarations #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed some duplication and wondered if it was possible to remove it. Then I stumbled upon this thread which provided a solution: https://discourse.llvm.org/t/how-to-add-new-content-to-extraclassdeclaration-in-subclasses/71537 The idea is to declare the common class declaration in the base class and concatenate it with the child-specific declarations. In some cases, the field was being overriden only to be set to the same value as the parent. In such cases, I simply removed the override.
ghpvnist
added
Migrate to MHLO
ghpvnist
approved these changes
Feb 6, 2024
|
Thanks, I'll look into it! |
mlevesquedion
deleted the
avoid-redundant-respecification-of-extra-class-decls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some duplication and wondered if it was possible to remove it. Then I stumbled upon this thread which provided a solution: https://discourse.llvm.org/t/how-to-add-new-content-to-extraclassdeclaration-in-subclasses/71537
The idea is to declare the common class declaration in the base class and concatenate it with the child-specific declarations.
In some cases, the field was being overriden only to be set to the same value as the parent. In such cases, I simply removed the override.